NVMe sample: Fix nvme ids #446
Open
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenShift image has the NVMe `hostid` and `hostnqn` hardcoded, so it ends up being the same in all the control plane nodes, which is problematic. This `MachineConfig` fixes this issue by recreating both files when the `hostid` doesn't match the system-uuid of the machine it is running on. Bugs: - https://issues.redhat.com/browse/OCPBUGS-34629 - openshift/os#1519 - openshift/os#1520
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
ASBishop
reviewed
Sep 26, 2024
| metadata: | ||
| labels: | ||
| component: fix-nvme-ids | ||
| machineconfiguration.openshift.io/role: master |
There was a problem hiding this comment.
Sorry, I just spotted this now, but should the role be worker? I think our other machineConfig specify master nodes, and that works in our small environments where nodes are both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift image has the NVMe
hostidandhostnqnhardcoded, so it ends up being the same in all the control plane nodes, which is problematic.This
MachineConfigfixes this issue by recreating both files when thehostiddoesn't match the system-uuid of the machine it is running on.Bugs:
/usr/etc/nvme/hostid/usr/etc/nvme/hostnqnopenshift/os#1519